Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ww datap 36 close hover state #468

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

wwhorton
Copy link
Contributor

The close button on notifications doesn't indicate in any way that it's actionable. I changed the cursor to a pointer and changed the fill from @pacific to @gray to match the close buttons elsewhere in the app.

Changes

  • added cursor: pointer and changed fill to @gray in Warning.less

Testing

  • Visit localhost:3000/data-research/consumer-complaints/search/?company_response=Closed&dataNormalization=None&dateRange=All&date_received_max=2021-12-23&date_received_min=2011-12-01&has_narrative=true&searchField=all&tab=Map
  • Verify that the color of the 'X' matches the 'X' buttons elsewhere, such as in the date filter
  • Mouse over the 'X' and the cursor should turn into a pointer

Screenshots

Screenshot 2023-09-29 at 12 09 50 PM

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just FYI it looks like the commit from #467 snuck its way into this PR.

@wwhorton wwhorton added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit 358879f Oct 4, 2023
2 checks passed
@wwhorton wwhorton deleted the ww-DATAP-36-close-hover-state branch October 4, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants